Handle VLAN ranges in connection requests #240
Conversation
Turns out that temanager != self.temanager In order to avoid confusion, we probably should not have a self.temanager at all.
This way we can form a short name
So that we can find out what VLAN range was requested
The comment is not quite a TODO, just an explanation about the way things are.
|
This works mostly. There are some edge cases I should address, and error handling needs more tests. I will address them in follow-up PRs. |
There was a problem hiding this comment.
@sajith Thanks for the enhancement, and the unittest cases are great.
Just one comment on the added codes (lines 962-992) in _find_common_vlan_on_link(): It requires that (1) the request vlan ranges are the same on the ingress port and egress port; (2) the same vlan range on all the intermediate ports on the path.
It's stricter than the single vlan case, where an arbitrary vlan can be picked on the intermediate inter-oxp link.
Do I understand it correctly?
|
@sajith I changed one line for an unrelated issue: Internal server error while submitting a request with VLAN out of the allowed range atlanticwave-sdx/sdx-controller#356. |
Resolves #230.